Merge branch 'MDL-64551-35' of git://github.com/rezaies/moodle into M…

…OODLE_35_STABLE
moodle · Feb 6, 2019 · c59ad63 · c59ad63
2 parents ab2a6da + c9d4bb2
commit c59ad63
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/question/classes/bank/tags_action_column.php b/question/classes/bank/tags_action_column.php
@@ -50,14 +50,12 @@ public function get_name() {
      * @param string $rowclasses
      */
     protected function display_content($question, $rowclasses) {
-        global $DB;
-
         if (\core_tag_tag::is_enabled('core_question', 'question') &&
                 question_has_capability_on($question, 'view')) {
 
             $cantag = question_has_capability_on($question, 'tag');
             $qbank = $this->qbank;
-            $url = $qbank->edit_question_url($question->id);
+            $url = new \moodle_url($qbank->edit_question_url($question->id));
             $editingcontext = $qbank->get_most_specific_context();
 
             $this->print_tag_icon($question->id, $url, $cantag, $editingcontext->id);
@@ -68,11 +66,11 @@ protected function display_content($question, $rowclasses) {
      * Build and print the tags icon.
      *
      * @param int $id The question ID.
-     * @param string $url Editing question url.
+     * @param \moodle_url $url Editing question url.
      * @param bool $cantag Whether the user can tag questions or not.
      * @param int $contextid Question category context ID.
      */
-    protected function print_tag_icon($id, $url, $cantag, $contextid) {
+    protected function print_tag_icon($id, \moodle_url $url, $cantag, $contextid) {
         global $OUTPUT;
 
         $params = [