MDL-69542 core_lib: make lti tool generator default to legacy version

This means existing tests won't need to change.
moodle · Feb 11, 2022 · c9636d2 · c9636d2
1 parent 4d8a078
commit c9636d2
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/lib/testing/generator/data_generator.php b/lib/testing/generator/data_generator.php
@@ -1097,10 +1097,15 @@ public function create_lti_tool($data = array()) {
             $data->status = ENROL_INSTANCE_ENABLED;
         }
 
+        // Default to legacy lti version.
+        if (empty($data->ltiversion) || !in_array($data->ltiversion, ['LTI-1p0/LTI-2p0', 'LTI-1p3'])) {
+            $data->ltiversion = 'LTI-1p0/LTI-2p0';
+        }
+
         // Add some extra necessary fields to the data.
-        $data->name = 'Test LTI';
-        $data->roleinstructor = $studentrole->id;
-        $data->rolelearner = $teacherrole->id;
+        $data->name = $data->name ?? 'Test LTI';
+        $data->roleinstructor = $teacherrole->id;
+        $data->rolelearner = $studentrole->id;
 
         // Get the enrol LTI plugin.
         $enrolplugin = enrol_get_plugin('lti');