Skip to content

Commit

Permalink
MDL-50509 datalib: Fix the typo in the variable name
Browse files Browse the repository at this point in the history
The line is supposed to sanitize the function parameter.
  • Loading branch information
mudrd8mz committed Jun 8, 2015
1 parent 17abbfb commit cdc6938
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion lib/datalib.php
Expand Up @@ -1769,7 +1769,10 @@ function get_logs_usercourse($userid, $courseid, $coursestart) {
$params['courseid'] = $courseid;
}
$params['userid'] = $userid;
$$coursestart = (int)$coursestart; // note: unfortunately pg complains if you use name parameter or column alias in GROUP BY
// We have to sanitize this param ourselves here instead of relying on DB.
// Postgres complains if you use name parameter or column alias in GROUP BY.
// See MDL-27696 and 51c3e85 for details.
$coursestart = (int)$coursestart;

return $DB->get_records_sql("SELECT FLOOR((time - $coursestart)/". DAYSECS .") AS day, COUNT(*) AS num
FROM {log}
Expand Down

0 comments on commit cdc6938

Please sign in to comment.