MDL-66259 quiz responses: fix unrealistic test setup

moodle · Apr 24, 2020 · d37c613 · d37c613
1 parent 15ffdf7
commit d37c613
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/mod/quiz/report/responses/tests/fixtures/questions00.csv b/mod/quiz/report/responses/tests/fixtures/questions00.csv
@@ -4,4 +4,4 @@ slot,type,which,cat,mark,overrides.hint.0.text,overrides.hint.0.format,overrides
 ,numerical,,rand,1,"Hint 1",0,"Hint 2",0,"Hint 3",0,"Hint 4",0,0
 2,calculatedsimple,sumwithvariants,maincat,1,"Hint 1",0,"Hint 2",0,"Hint 3",0,"Hint 4",0,0
 3,match,,maincat,1,"Hint 1",0,"Hint 2",0,"Hint 3",0,"Hint 4",0,0
-4,truefalse,,maincat,1,"Hint 1",0,"Hint 2",0,"Hint 3",0,"Hint 4",0,0
+4,truefalse,,maincat,1,"",0,"",0,"",0,"",0,0
diff --git a/mod/quiz/tests/attempt_walkthrough_from_csv_test.php b/mod/quiz/tests/attempt_walkthrough_from_csv_test.php
@@ -94,6 +94,11 @@ public function create_quiz($quizsettings, $qs) {
             if ($q['type'] !== 'random') {
                 // Don't actually create random questions here.
                 $overrides = array('category' => $cat->id, 'defaultmark' => $q['mark']) + $q['overrides'];
+                if ($q['type'] === 'truefalse') {
+                    // True/false question can never have hints, but sometimes we need to put them
+                    // in the CSV file, to keep it rectangular.
+                    unset($overrides['hint']);
+                }
                 $question = $questiongenerator->create_question($q['type'], $q['which'], $overrides);
                 $q['id'] = $question->id;