Skip to content

Commit

Permalink
MDL-27703 gradebook: altered an sql query in the user report. join wi…
Browse files Browse the repository at this point in the history
…th no on clause causes an error in some DBs
  • Loading branch information
andrew authored and andrew committed Nov 16, 2011
1 parent 6be90ce commit d3e3034
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions grade/report/user/lib.php
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@ function calculate_averages() {
// Then left join with grade_grades and look for rows with null final grade (which includes grade items with no grade_grade) // Then left join with grade_grades and look for rows with null final grade (which includes grade items with no grade_grade)
$sql = "SELECT gi.id, COUNT(u.id) AS count $sql = "SELECT gi.id, COUNT(u.id) AS count
FROM {grade_items} gi FROM {grade_items} gi
JOIN {user} u JOIN {user} u ON u.deleted = 0
JOIN ($enrolledsql) je ON je.id = u.id JOIN ($enrolledsql) je ON je.id = u.id
JOIN ( JOIN (
SELECT DISTINCT ra.userid SELECT DISTINCT ra.userid
Expand All @@ -660,10 +660,9 @@ function calculate_averages() {
AND ra.contextid " . get_related_contexts_string($this->context) . " AND ra.contextid " . get_related_contexts_string($this->context) . "
) rainner ON rainner.userid = u.id ) rainner ON rainner.userid = u.id
LEFT JOIN {grade_grades} gg LEFT JOIN {grade_grades} gg
ON (gg.itemid = gi.id AND gg.userid = u.id AND gg.finalgrade IS NOT NULL AND gg.hidden = 0) ON (gg.itemid = gi.id AND gg.userid = u.id AND gg.finalgrade IS NOT NULL AND gg.hidden = 0)
$groupsql $groupsql
WHERE gi.courseid = :courseid WHERE gi.courseid = :courseid
AND u.deleted = 0
AND gg.finalgrade IS NULL AND gg.finalgrade IS NULL
$groupwheresql $groupwheresql
GROUP BY gi.id"; GROUP BY gi.id";
Expand Down

0 comments on commit d3e3034

Please sign in to comment.