Merge branch 'MDL-75312-400' of https://github.com/paulholden/moodle …

…into MOODLE_400_STABLE
moodle · Aug 17, 2022 · d5c66fa · d5c66fa
2 parents e9a7520 + c83345a
commit d5c66fa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/question/classes/local/bank/random_question_loader.php b/question/classes/local/bank/random_question_loader.php
@@ -303,7 +303,7 @@ public function get_questions($categoryid, $includesubcategories, $tagids = [],
                       FROM {question} q
                       JOIN {question_versions} qv ON qv.questionid = q.id
                       JOIN {question_bank_entries} qbe ON qbe.id = qv.questionbankentryid
-                      {$condition}) q";
+                      {$condition}) q ORDER BY q.id";
 
             return $DB->get_records_sql($sql, $param, $offset, $limit);
         } else {

diff --git a/question/tests/externallib_test.php b/question/tests/externallib_test.php
@@ -14,16 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-/**
- * Question external functions tests.
- *
- * @package    core_question
- * @category   external
- * @copyright  2016 Pau Ferrer <pau@moodle.com>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- * @since      Moodle 3.1
- */
-
 namespace core_question;
 
 use core_question_external;
@@ -40,6 +30,7 @@
  * Question external functions tests
  *
  * @package    core_question
+ * @covers     \core_question_external
  * @category   external
  * @copyright  2016 Pau Ferrer <pau@moodle.com>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later