MDL-38528 qtype_calc* dataset forms: disable short-forms for now.

At the moment using short-forms no these forms really does not work. In
future is may be possible to do a complete overhaul, but for now, just
disabling short-forms is a simple fix.

question/type/calculated/datasetdefinitions_form.php

@@ -71,7 +71,10 @@ public function __construct($submiturl, $question) {
 
     protected function definition() {
         global $SESSION;
+
         $mform = $this->_form;
+        $mform->setDisableShortforms();
+
         $possibledatasets = $this->qtypeobj->find_dataset_names($this->question->questiontext);
         $mandatorydatasets = array();
         if (isset($this->question->options->answers)) {

question/type/calculated/datasetitems_form.php

@@ -111,6 +111,8 @@ protected function definition() {
                 $labelsharedwildcard = get_string("sharedwildcard", "qtype_calculated");
 
         $mform =& $this->_form;
+        $mform->setDisableShortforms();
+
         $strquestionlabel = $this->qtypeobj->comment_header($this->question);
         if ($this->maxnumber != -1 ) {
             $this->noofitems = $this->maxnumber;