Skip to content

Commit

Permalink
MDL-78542 mod_url: clicktoopen lang string fix
Browse files Browse the repository at this point in the history
- Improve the grammatical structure of the lang string.
- Remove the mention of "link", for sighted users, it should already
be obvious that it's a link. For screen reader users, screen readers
already announce links. So it would be confusing for them to hear
something like "Click 'Moodle.org, link' link to open resource"
  • Loading branch information
junpataleta committed Jun 30, 2023
1 parent 628c5c0 commit d6fc042
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion mod/url/lang/en/url.php
Expand Up @@ -23,7 +23,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

$string['clicktoopen'] = 'Click {$a} link to open resource.';
$string['clicktoopen'] = 'Click on {$a} to open the resource.';
$string['configdisplayoptions'] = 'Select all options that should be available, existing settings are not modified. Hold CTRL key to select multiple fields.';
$string['configframesize'] = 'When a web page or an uploaded file is displayed within a frame, this value is the height (in pixels) of the top frame (which contains the navigation).';
$string['configrolesinparams'] = 'Should customised role names (from the course settings) be available as variables for URL parameters?';
Expand Down
4 changes: 3 additions & 1 deletion mod/url/tests/behat/url_activity_completion.feature
Expand Up @@ -31,7 +31,9 @@ Feature: View activity completion information in the URL resource
| completionview | 1 |
| display | 0 |
When I am on the "Music history" "url activity" page logged in as teacher1
Then "Music history" should have the "View" completion condition
Then "Music history" "link" should exist
And I should see "Click on Music history to open the resource."
And "Music history" should have the "View" completion condition

Scenario: View automatic completion items in automatic display mode as student
Given the following "activity" exists:
Expand Down

0 comments on commit d6fc042

Please sign in to comment.