MDL-71395 block_tag_youtube: sometimes exception may have empty message

moodle · May 6, 2021 · d7d6091 · d7d6091
1 parent 1c9837a
commit d7d6091
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/blocks/tag_youtube/edit_form.php b/blocks/tag_youtube/edit_form.php
@@ -42,19 +42,21 @@ protected function specific_definition($mform) {
 
         // Category setting.
         $categorychoices = ['0' => get_string('anycategory', 'block_tag_youtube')];
+        $hascategoryerror = false;
         $categoryerror = '';
 
         try {
             // Get all video categories through an API call and add them to the category list.
             $categorychoices += $this->block->get_categories();
         } catch (Exception $e) {
+            $hascategoryerror = true;
             $categoryerror = $e->getMessage();
         }
         $mform->addElement('select', 'config_category', get_string('category', 'block_tag_youtube'),
             $categorychoices);
         $mform->setDefault('config_category', 0);
 
-        if ($categoryerror) {
+        if ($hascategoryerror) {
             $notification = $OUTPUT->notification(get_string('categoryerror', 'block_tag_youtube', $categoryerror),
                 'error');
             $mform->addElement('static', 'config_category_error', '', $notification);