MDL-75116 mod_feedback: Check array values exist before using them

Without this, the @list will emit a PHP warning under php8.0+ when the array doesn't have a second element to assign.
moodle · Jul 4, 2022 · e088975 · e088975
1 parent bab7bdc
commit e088975
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/mod/feedback/item/multichoice/lib.php b/mod/feedback/item/multichoice/lib.php
@@ -437,14 +437,20 @@ public function get_info($item) {
         $info->horizontal = false;
 
         $parts = explode(FEEDBACK_MULTICHOICE_TYPE_SEP, $item->presentation);
-        @list($info->subtype, $info->presentation) = $parts;
+        $info->subtype = $parts[0];
+        if (count($parts) > 1) {
+            $info->presentation = $parts[1];
+        }
         if (!isset($info->subtype)) {
             $info->subtype = 'r';
         }
 
         if ($info->subtype != 'd') {
             $parts = explode(FEEDBACK_MULTICHOICE_ADJUST_SEP, $info->presentation);
-            @list($info->presentation, $info->horizontal) = $parts;
+            $info->presentation = $parts[0];
+            if (count($parts) > 1) {
+                $info->horizontal = $parts[1];
+            }
             if (isset($info->horizontal) AND $info->horizontal == 1) {
                 $info->horizontal = true;
             } else {

diff --git a/mod/feedback/item/multichoicerated/lib.php b/mod/feedback/item/multichoicerated/lib.php
@@ -377,15 +377,21 @@ public function get_info($item) {
         $info->horizontal = false;
 
         $parts = explode(FEEDBACK_MULTICHOICERATED_TYPE_SEP, $item->presentation);
-        @list($info->subtype, $info->presentation) = $parts;
+        $info->subtype = $parts[0];
+        if (count($parts) > 1) {
+            $info->presentation = $parts[1];
+        }
 
         if (!isset($info->subtype)) {
             $info->subtype = 'r';
         }
 
         if ($info->subtype != 'd') {
             $parts = explode(FEEDBACK_MULTICHOICERATED_ADJUST_SEP, $info->presentation);
-            @list($info->presentation, $info->horizontal) = $parts;
+            $info->presentation = $parts[0];
+            if (count($parts) > 1) {
+                $info->horizontal = $parts[1];
+            }
 
             if (isset($info->horizontal) AND $info->horizontal == 1) {
                 $info->horizontal = true;