MDL-73405 libraries: php80 compatibility fix to Horde Imap Client

The fix is already available upstream for versions 2.30.4 and up See horde/Imap_Client#13
moodle · Dec 19, 2021 · e14c046 · e14c046
1 parent d02364e
commit e14c046
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/horde/framework/Horde/Imap/Client/Exception/ServerResponse.php b/lib/horde/framework/Horde/Imap/Client/Exception/ServerResponse.php
@@ -44,14 +44,14 @@ class Horde_Imap_Client_Exception_ServerResponse extends Horde_Imap_Client_Excep
     /**
      * Constructor.
      *
-     * @param string $msg                                       Error message.
+     * @param string|null $msg                                  Error message.
      * @param integer $code                                     Error code.
      * @param Horde_Imap_Client_Interaction_Server $server      Server ob.
      * @param Horde_Imap_Client_Interaction_Pipeline $pipeline  Pipeline ob.
      */
     public function __construct(
-        $msg = null,
-        $code = 0,
+        $msg,
+        $code,
         Horde_Imap_Client_Interaction_Server $server,
         Horde_Imap_Client_Interaction_Pipeline $pipeline
     )

diff --git a/lib/horde/readme_moodle.txt b/lib/horde/readme_moodle.txt
@@ -36,3 +36,8 @@ do
     cp -Rf $locale/* $target/locale
   fi
 done
+
+Local modifications:
+- lib/Horde/Imap/Client/Exception/ServerResponse.php has been minimally modified for php80 compatibility
+  The fix applied is already upstream, see https://github.com/horde/Imap_Client/pull/13 and it's available
+  in Imap_Client 2.30.4 and up. See MDL-73405 for more details.