MDL-19756 Showing exceptions only in DEBUG_DEVELOPER mode

moodle · Aug 13, 2009 · e57c283 · e57c283
1 parent 3d1df2f
commit e57c283
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php
@@ -1676,7 +1676,7 @@ public function select($select) {
      */
     public function radio($option, $name='unnamed') {
         static $currentradio = array();
-        
+
         if (empty($currentradio[$name])) {
             $currentradio[$name] = 0;
         }
@@ -1847,6 +1847,10 @@ public function fatal_error($message, $moreinfourl, $link, $backtrace,
 
         $output = '';
 
+        if (!debugging('', DEBUG_DEVELOPER)) {
+            return false;
+        }
+
         if ($this->has_started()) {
             $output .= $this->opencontainers->pop_all_but_last();
         } else {
@@ -1861,18 +1865,16 @@ public function fatal_error($message, $moreinfourl, $link, $backtrace,
                 get_string('moreinformation') . '</a></p>';
         $output .= $this->box($message, 'errorbox');
 
-        if (debugging('', DEBUG_DEVELOPER)) {
-            if ($showerrordebugwarning) {
-                $output .= $this->notification('error() is a deprecated function. ' .
-                        'Please call print_error() instead of error()', 'notifytiny');
-            }
-            if (!empty($debuginfo)) {
-                $output .= $this->notification($debuginfo, 'notifytiny');
-            }
-            if (!empty($backtrace)) {
-                $output .= $this->notification('Stack trace: ' .
-                        format_backtrace($backtrace), 'notifytiny');
-            }
+        if ($showerrordebugwarning) {
+            $output .= $this->notification('error() is a deprecated function. ' .
+                    'Please call print_error() instead of error()', 'notifytiny');
+        }
+        if (!empty($debuginfo)) {
+            $output .= $this->notification($debuginfo, 'notifytiny');
+        }
+        if (!empty($backtrace)) {
+            $output .= $this->notification('Stack trace: ' .
+                    format_backtrace($backtrace), 'notifytiny');
         }
 
         if (!empty($link)) {