MDL-29807 Fixed invalid add_record_snapshot references and also inexi…

…stent check of empty short names
moodle · Mar 17, 2014 · eb625bc · eb625bc
1 parent 0a8ab74
commit eb625bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/admin/webservice/forms.php b/admin/webservice/forms.php
@@ -158,9 +158,12 @@ function validation($data, $files) {
         $errors = parent::validation($data, $files);
 
         // Add field validation check for duplicate shortname.
-        if ($service = $DB->get_record('external_services', array('shortname' => $data['shortname']), '*', IGNORE_MULTIPLE)) {
-            if (empty($data['id']) || $service->id != $data['id']) {
-                $errors['shortname'] = get_string('shortnametaken', 'webservice', $service->name);
+        // Allow duplicated "empty" shortnames.
+        if (!empty($data['shortname'])) {
+            if ($service = $DB->get_record('external_services', array('shortname' => $data['shortname']), '*', IGNORE_MULTIPLE)) {
+                if (empty($data['id']) || $service->id != $data['id']) {
+                    $errors['shortname'] = get_string('shortnametaken', 'webservice', $service->name);
+                }
             }
         }
 

diff --git a/admin/webservice/service.php b/admin/webservice/service.php
@@ -84,7 +84,6 @@
             'objectid' => $servicedata->id
         );
         $event = \core\event\webservice_service_created::create($params);
-        $event->add_record_snapshot('external_services', $servicedata);
         $event->trigger();
 
         //redirect to the 'add functions to service' page
@@ -99,7 +98,6 @@
             'objectid' => $servicedata->id
         );
         $event = \core\event\webservice_service_updated::create($params);
-        $event->add_record_snapshot('external_services', $servicedata);
         $event->trigger();
     }