Permalink
Browse files

MDL-13314 count_role_users was showing different count to those retur…

…ned from

get_role_users(), based on patch from Patrick Pollett
merged from MOODLE_19_STABLE
  • Loading branch information...
1 parent e08dc18 commit f405c6e4d8985e3438be9c7dbec6d6f2fa015718 poltawski committed Feb 5, 2008
Showing with 7 additions and 4 deletions.
  1. +7 −4 lib/accesslib.php
View
11 lib/accesslib.php
@@ -4927,10 +4927,13 @@ function count_role_users($roleid, $context, $parent=false) {
$parentcontexts = '';
}
- $SQL = "SELECT count(*)
- FROM {$CFG->prefix}role_assignments r
- WHERE (r.contextid = $context->id $parentcontexts)
- AND r.roleid = $roleid";
+ $SQL = "SELECT count(u.id)
+ FROM {$CFG->prefix}role_assignments r
+ JOIN {$CFG->prefix}user u
+ ON u.id = r.userid
+ WHERE (r.contextid = $context->id $parentcontexts)
+ AND r.roleid = $roleid
+ AND u.deleted = 0";
return count_records_sql($SQL);
}

0 comments on commit f405c6e

Please sign in to comment.