Skip to content

Commit

Permalink
MDL-51719 atto_rtl: RTL/LTR buttons now indicate state
Browse files Browse the repository at this point in the history
Previously the RTL buttons did not indiciate wether RTL or LTR was
selected. Thanks to Andrew Nicols for guiding how to do this.
  • Loading branch information
danpoltawski committed Nov 27, 2015
1 parent b9c333f commit f788c16
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
Expand Up @@ -43,7 +43,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito
title: direction,
buttonName: direction,
callback: this._toggleRTL,
callbackArgs: direction
callbackArgs: direction,
tags: '[dir=ltr]'
});

direction = 'rtl';
Expand All @@ -52,7 +53,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito
title: direction,
buttonName: direction,
callback: this._toggleRTL,
callbackArgs: direction
callbackArgs: direction,
tags: '[dir=rtl]'
});
},

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -43,7 +43,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito
title: direction,
buttonName: direction,
callback: this._toggleRTL,
callbackArgs: direction
callbackArgs: direction,
tags: '[dir=ltr]'
});

direction = 'rtl';
Expand All @@ -52,7 +53,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito
title: direction,
buttonName: direction,
callback: this._toggleRTL,
callbackArgs: direction
callbackArgs: direction,
tags: '[dir=rtl]'
});
},

Expand Down
6 changes: 4 additions & 2 deletions lib/editor/atto/plugins/rtl/yui/src/button/js/button.js
Expand Up @@ -41,7 +41,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito
title: direction,
buttonName: direction,
callback: this._toggleRTL,
callbackArgs: direction
callbackArgs: direction,
tags: '[dir=ltr]'
});

direction = 'rtl';
Expand All @@ -50,7 +51,8 @@ Y.namespace('M.atto_rtl').Button = Y.Base.create('button', Y.M.editor_atto.Edito
title: direction,
buttonName: direction,
callback: this._toggleRTL,
callbackArgs: direction
callbackArgs: direction,
tags: '[dir=rtl]'
});
},

Expand Down

0 comments on commit f788c16

Please sign in to comment.