MDL-46960 completion: trigger event after clearing cache

moodle · Apr 2, 2015 · f797471 · f797471
1 parent 345c6a1
commit f797471
Showing 1 changed file with 13 additions and 13 deletions.
diff --git a/lib/completionlib.php b/lib/completionlib.php
@@ -921,7 +921,7 @@ public function get_data($cm, $wholecourse = false, $userid = 0, $modinfo = null
         }
 
         // Not there, get via SQL
-        if ($wholecourse) {
+        if ($usecache && $wholecourse) {
             // Get whole course data for cache
             $alldatabycmc = $DB->get_records_sql("
     SELECT
@@ -1019,18 +1019,6 @@ public function internal_set_data($cm, $data) {
         $cmcontext = context_module::instance($data->coursemoduleid, MUST_EXIST);
         $coursecontext = $cmcontext->get_parent_context();
 
-        // Trigger an event for course module completion changed.
-        $event = \core\event\course_module_completion_updated::create(array(
-            'objectid' => $data->id,
-            'context' => $cmcontext,
-            'relateduserid' => $data->userid,
-            'other' => array(
-                'relateduserid' => $data->userid
-            )
-        ));
-        $event->add_record_snapshot('course_modules_completion', $data);
-        $event->trigger();
-
         $completioncache = cache::make('core', 'completion');
         if ($data->userid == $USER->id) {
             // Update module completion in user's cache.
@@ -1047,6 +1035,18 @@ public function internal_set_data($cm, $data) {
             // Remove another user's completion cache for this course.
             $completioncache->delete($data->userid . '_' . $cm->course);
         }
+
+        // Trigger an event for course module completion changed.
+        $event = \core\event\course_module_completion_updated::create(array(
+            'objectid' => $data->id,
+            'context' => $cmcontext,
+            'relateduserid' => $data->userid,
+            'other' => array(
+                'relateduserid' => $data->userid
+            )
+        ));
+        $event->add_record_snapshot('course_modules_completion', $data);
+        $event->trigger();
     }
 
      /**