MDL-46978 gradebook: Edit grade item changes visibility of category

moodle · Oct 3, 2014 · f9f37ec · f9f37ec
1 parent e26204c
commit f9f37ec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/lib/grade/grade_category.php b/lib/grade/grade_category.php
@@ -1691,14 +1691,11 @@ public function set_hidden($hidden, $cascade=false) {
         }
 
         //if marking category visible make sure parent category is visible MDL-21367
-        if( !$hidden ) {
+        if ($this->is_hidden() != $hidden) {
             $category_array = grade_category::fetch_all(array('id'=>$this->parent));
             if ($category_array && array_key_exists($this->parent, $category_array)) {
                 $category = $category_array[$this->parent];
-                //call set_hidden on the category regardless of whether it is hidden as its parent might be hidden
-                //if($category->is_hidden()) {
-                    $category->set_hidden($hidden, false);
-                //}
+                $category->set_hidden($hidden, false);
             }
         }
     }

diff --git a/lib/grade/grade_item.php b/lib/grade/grade_item.php
@@ -594,14 +594,11 @@ public function set_hidden($hidden, $cascade=false) {
         }
 
         //if marking item visible make sure category is visible MDL-21367
-        if( !$hidden ) {
+        if ($this->is_hidden() != $hidden) {
             $category_array = grade_category::fetch_all(array('id'=>$this->categoryid));
             if ($category_array && array_key_exists($this->categoryid, $category_array)) {
                 $category = $category_array[$this->categoryid];
-                //call set_hidden on the category regardless of whether it is hidden as its parent might be hidden
-                //if($category->is_hidden()) {
-                    $category->set_hidden($hidden, false);
-                //}
+                $category->set_hidden($hidden, false);
             }
         }
     }