mirrored from git://git.moodle.org/moodle.git
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MDL-57604 mod_assign: fix incorrect user being selector from chooser
Previously there was a logic bug where by if some students were filtered from the list, the label for another student could be attached to the 'filered' student. This fix reworks the promises a bit so we render the student summary and then build an row with the explict user id, rather than itterating through the array later. I also remove the storing of the initial promise in a varible because this is an easy way to introduce a bug (not waiting for the .then() chained promise)
- Loading branch information
1 parent
a09a987
commit fb5655b
Showing
2 changed files
with
13 additions
and
20 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters