mirrored from git://git.moodle.org/moodle.git
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MDL-67668 behat: Add inplace editable field type
This commit promotes the Inplace Editable field to a first-class form element by introducing a new partial selector for inplace editable fields, and teaching the field manager how to recognise these, then introducing a new field type which can handle setting values for this field.
- Loading branch information
1 parent
548da2c
commit fd71823
Showing
5 changed files
with
130 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
@tool_behat | ||
Feature: Verify that the inplace editable field works as expected | ||
In order to use behat step definitions | ||
As a test write | ||
I need to ensure that the inplace editable works in forms | ||
|
||
Background: | ||
Given the following "course" exists: | ||
| fullname | Course 1 | | ||
| shortname | C1 | | ||
And the following "activities" exist: | ||
| activity | course | name | idnumber | | ||
| forum | C1 | My first forum | forum1 | | ||
| assign | C1 | My first assignment | assign1 | | ||
| quiz | C1 | My first quiz | quiz1 | | ||
And I log in as "admin" | ||
And I am on "Course 1" course homepage with editing mode on | ||
|
||
@javascript | ||
Scenario: Using an inplace editable updates the name of an activity | ||
When I set the field "Edit title" in the "My first assignment" "activity" to "Coursework submission" | ||
Then I should see "Coursework submission" | ||
And I should not see "My first assignment" | ||
But I should see "My first forum" | ||
And I should see "My first quiz" | ||
And I set the field "Edit title" in the "Coursework submission" "activity" to "My first assignment" | ||
And I should not see "Coursework submission" | ||
But I should see "My first assignment" | ||
And I should see "My first forum" | ||
And I should see "My first quiz" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
<?php | ||
// This file is part of Moodle - http://moodle.org/ | ||
// | ||
// Moodle is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
// | ||
// Moodle is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
// | ||
// You should have received a copy of the GNU General Public License | ||
// along with Moodle. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
/** | ||
* Custom interaction with inplace editable elements. | ||
* | ||
* @package core_form | ||
* @category test | ||
* @copyright 2019 Andrew Nicols <andrew@nicols.co.uk> | ||
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | ||
*/ | ||
|
||
// NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php. | ||
|
||
require_once(__DIR__ . '/behat_form_text.php'); | ||
|
||
/** | ||
* Custom interaction with inplace editable elements. | ||
* | ||
* @package core_form | ||
* @category test | ||
* @copyright 2019 Andrew Nicols <andrew@nicols.co.uk> | ||
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | ||
*/ | ||
class behat_form_inplaceeditable extends behat_form_text { | ||
/** | ||
* Sets the value to a field. | ||
* | ||
* @param string $value | ||
* @return void | ||
*/ | ||
public function set_value($value) { | ||
// Require JS to run this step. | ||
self::require_javascript(); | ||
|
||
// Click to enable editing. | ||
self::execute( | ||
'behat_general::i_click_on_in_the', | ||
[ | ||
'[data-inplaceeditablelink]', | ||
'css_element', | ||
$this->field, | ||
'NodeElement', | ||
] | ||
); | ||
|
||
// Note: It is not possible to use the NodeElement->keyDown() and related functions because | ||
// this can trigger a focusOnElement call each time. | ||
// Instead use the behat_base::type_keys() function. | ||
|
||
// The inplace editable selects all existing content on focus. | ||
// Clear the existing value. | ||
self::type_keys($this->session, [behat_keys::BACKSPACE]); | ||
|
||
// Type in the new value, followed by ENTER to save the value. | ||
self::type_keys($this->session, array_merge( | ||
str_split($value), | ||
[behat_keys::ENTER] | ||
)); | ||
} | ||
} |