Merged MDL-13810 Fixed check for ul.timeaccess

moodle · Mar 6, 2008 · fffb5d2 · fffb5d2
1 parent 68be1fe
commit fffb5d2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/accesslib.php b/lib/accesslib.php
@@ -4525,11 +4525,11 @@ function get_users_by_capability($context, $capability, $fields='', $sort='',
     $sortby = $sort ? " ORDER BY $sort " : '';
 
     // User lastaccess JOIN
-    if ($sort == 'ul.timeaccess') {
+    if (strpos($sort, 'ul.timeaccess') === FALSE) {  // user_lastaccess is not required MDL-13810
+        $uljoin = '';
+    } else {
         $uljoin = "LEFT OUTER JOIN {$CFG->prefix}user_lastaccess ul 
                          ON (ul.userid = u.id AND ul.courseid = {$context->instanceid})";
-    } else {
-        $uljoin = '';
     }
 
     //