Add option to hide SSID

[martignoni]

See this forum discussion.

[martignoni]

Create GUI for this https://raspberrypi.stackexchange.com/questions/56327/how-to-set-pi-up-as-a-hidden-wifi-access-point.

[adpe]

@martignoni: Can I contribute something or are you already working on it?

[martignoni]

I'm working on it, but as this is a Moodle plugin, if you've some experience of Moodle plugin programming, I'd be glad to look at your PR.

Be sure please to conform to the Moodle coding style.

[martignoni]

Implementation done. Needs testing now.

[adpe]

Thanks for working on it. I copied the two lines manually to the hostapd.conf. So this automated init part is not covered by my tests. Here is my review:

[y] Syntax (I'm not so experienced, please take it with attention)
[y] Output (Expected result on admin view)
[y] Language (en/fr)
[-] Databases
[y] Testing (Does the function do what it should => Moodle plugin and Shell script)
[-] Security
[-] Performance and Clustering
[n] Documentation
[y] Git
[-] Third party code
[-] Sanity check
[-] Icons

Just some questions:

• How does the trigger work? I've noticed that the filepermissions and owner of changewifisettings.sh changed after saving new Wi-Fi settings. They're not anymore moodlebox:www-data, they're root:root.
• Does the german translation will be made with AMOS? Why isn't just en in the plugin and fr will done with AMOS too? Is there a reason?
• Would it not be better, if the triggerfiles will be ignored from git? Would make sense to add these to .gitignore.

[martignoni]

Thanks for this review 👍

To your questions.

How does the trigger work?

There's an incron job that checks if the hidden triggerfile is changed. In this case, the script changewifisettings.sh is launched and sets the adequate parameters in hostapd.conf.

Does the german translation will be made with AMOS? Why isn't just en in the plugin and fr will done with AMOS too? Is there a reason?

The german translation is indeed done via AMOS (and other languages too), like in any Moodle plugin. The english file must be in the source (as per Moodle coding way). I keep the french language file here for archive reasons (but the strings are also translated in AMOS).

Would it not be better, if the triggerfiles will be ignored from git?

It was the case some time ago, but this broke the upgrade process. See issue #37.

[martignoni]

Tested. Works OK.