Unpin selenium 3.141.59-zinc (Chrome 79) so 89 takes the baton #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were waiting since some time ago to Chrome 89 to be released
and, because of that, we had selenium pinned to 3.141.59-zinc
version (Chrome 79).
The cause for staying sticky was this issue:
https://bugs.chromium.org/p/chromedriver/issues/detail?id=3682&q=&can=1&sort=-id
Chrome (and chromedriver) 89 have been released and Selenium has
already build the docker images for them:
https://github.com/SeleniumHQ/docker-selenium/releases/tag/3.141.59-20210311
So now we can unpin the old version and let the machinery to use the
latest versions available. That's what this PR does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were waiting since some time ago to Chrome 89 to be released
and, because of that, we had selenium pinned to 3.141.59-zinc
version (Chrome 79).
The cause for staying sticky was this issue:
https://bugs.chromium.org/p/chromedriver/issues/detail?id=3682&q=&can=1&sort=-id
Chrome (and chromedriver) 89 have been released and Selenium has
already build the docker images for them:
https://github.com/SeleniumHQ/docker-selenium/releases/tag/3.141.59-20210311
So now we can unpin the old version and let the machinery to use the
latest versions available. That's what this PR does.