Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type normalisation #126

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Type normalisation #126

merged 2 commits into from
Mar 20, 2024

Conversation

andrewnicols
Copy link
Contributor

This is part of a followup to #121. It:

  • moves the type validation to its own Util class. In retrospect I should have done so whilst writing the Sniff but I was waiting until I wrote the next sniff that used it. However, moving it here allows better unit testing
  • adds null, true, and false

It also moves the existing union type checks into the same TypeUtil class.
DNF + Intersection are separate followups.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (24bc48a) to head (6027bd8).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #126      +/-   ##
============================================
- Coverage     97.81%   97.81%   -0.01%     
+ Complexity      827      825       -2     
============================================
  Files            35       36       +1     
  Lines          2426     2425       -1     
============================================
- Hits           2373     2372       -1     
  Misses           53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7 stronk7 merged commit 6974134 into moodlehq:main Mar 20, 2024
9 checks passed
@james-cnz james-cnz mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants