Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sniff to detect missing docs for constants #129

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

andrewnicols
Copy link
Contributor

@andrewnicols andrewnicols commented Mar 22, 2024

Replaces constsdocumented check.

moodlehq/moodle-local_moodlecheck#140

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (e514246) to head (fbe6264).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #129      +/-   ##
============================================
+ Coverage     97.82%   97.84%   +0.02%     
- Complexity      826      835       +9     
============================================
  Files            36       36              
  Lines          2432     2463      +31     
============================================
+ Hits           2379     2410      +31     
  Misses           53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewnicols andrewnicols marked this pull request as ready for review March 22, 2024 14:44
andrewnicols added a commit to andrewnicols/moodle-local_moodlecheck that referenced this pull request Mar 22, 2024
andrewnicols added a commit to andrewnicols/moodle-local_moodlecheck that referenced this pull request Mar 22, 2024
andrewnicols added a commit to andrewnicols/moodle-local_moodlecheck that referenced this pull request Mar 22, 2024
andrewnicols added a commit to andrewnicols/moodle-local_moodlecheck that referenced this pull request Mar 22, 2024
Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stronk7 stronk7 merged commit 5af7ee0 into moodlehq:main Mar 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants