No relevant files #191
Merged
No relevant files #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this doesn't perform any check over arrays syntax, only array indexes. Covered with tests. Fixes moodlehq#189
As far as all the non-relevant code (namespace, uses, declare and defines) is also code without side effects, these files don't need the MOODLE_INTERNAL check). Covered with tests. This needs to be merged after moodlehq#190. Fixes moodlehq#188
|
Self-merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files containing exclusively non-relevant code are ok
As far as all the non-relevant code (namespace, uses, declare and
defines) is also code without side effects, these files don't need
the MOODLE_INTERNAL check).
Covered with tests.
This needs to be merged after #190.
Fixes #188