Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade PHPCompatibility to 7.1.2 #40

Closed
wants to merge 2 commits into from
Closed

Upgrade PHPCompatibility to 7.1.2 #40

wants to merge 2 commits into from

Conversation

polothy
Copy link
Contributor

@polothy polothy commented Mar 31, 2017

Downloaded the 7.1.2 release and dropped it into the codebase. This includes compatibility checks for PHP 7.1.

@polothy
Copy link
Contributor Author

polothy commented Mar 31, 2017

Having trouble testing this, the following doesn't work:

$ php local/codechecker/run.php mod/forum --runtime-set testVersion 7.1
Check some PHP code against the Moodle coding guidelines.
Options:
  --interactive, -i Stops after every file allowing to continue with the next
                    file or to repeat the check against the same one.
  --help, -h        Shows this information
Example:
  php run.php local/codechecker

@polothy
Fixing tests due to PHPCompatibility 7.1.2 upgrade
18d40b6 
* Sniff for invoking throw has been removed, see
  PHPCompatibility/PHPCompatibility#118
* Some sniffs about old functions changed from warnings to errors.
* Wording of some warnings/errors changed.
@polothy polothy mentioned this pull request May 23, 2017
Merged
@stronk7
Copy link
Member

stronk7 commented May 25, 2017

... looking ...

@stronk7
Copy link
Member

stronk7 commented May 27, 2017 •
edited

Just an update..

  • I've added PHPCompatibility 7.1.4 on top of this PR.
  • Running tests over different PHP/Moodle versions.
  • Will be releasing new codechecker plugin in some hours.

Surely after release, next issue to be attempted will be:

https://tracker.moodle.org/browse/CONTRIB-5158
(add support for testVersion param to both run.php and web UI)

Will comment here once I proceed, not sure if github auto-closes this when cherry-picking . Sure they do, by using cherry or so. They are sooo clever... :-)

Back soon...

@stronk7
Copy link
Member

stronk7 commented May 27, 2017

Yuppi, automated seem to be passing ok:

https://travis-ci.org/stronk7/moodle-local_codechecker/builds/236660176

Plus both web and cli runners also passed some exploratory testing. So it's time to release upstream...

@stronk7
Copy link
Member

stronk7 commented May 27, 2017

Done, v2.7.0 released including this:

It seems Github was not "clever" enough to see the commits already incorporated and prefers to conflict.. but they are there, so closing this, thanks Mark!

@stronk7 stronk7 closed this May 27, 2017
@polothy polothy deleted the updateCompatibility branch May 28, 2017 20:33
@polothy
Copy link
Contributor Author

polothy commented May 28, 2017

Thanks Eloy, as always, very much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@polothy @stronk7