Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider new lines as valid characters after operators #41

Merged
merged 1 commit into from Jan 20, 2018

Conversation

ankitagarwal
Copy link
Contributor

If after an operator new line character is encountered, we should not generate warnings or notices.

If after an operator new line character is encountered, we should not generate warnings or notices.
@timhunt
Copy link
Contributor

timhunt commented Oct 18, 2017

LOL. I just coded exactly this same fix (although I did not write a unit test). Please can we merge this! It gest a +1 from me.

@stronk7 stronk7 merged commit 0915b76 into moodlehq:master Jan 20, 2018
@stronk7
Copy link
Member

stronk7 commented Jan 20, 2018

Sorry for the delay, I had this and other PRs completely forgotten, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants