Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOBILE-4147 core,folder: Restore access to inline folders #3318

Draft
wants to merge 11 commits into
base: v4.1.x
Choose a base branch
from
Draft

MOBILE-4147 core,folder: Restore access to inline folders #3318

wants to merge 11 commits into from

Conversation

tasosb
Copy link
Contributor

@tasosb tasosb commented Jun 13, 2022

This PR restores access to inline folders that were previously inaccessible.
Inline folders are now displayed like the regular folders in the mobile app.
Changes:

  1. New core feature that can be set to true if the mobile app can produce a view for the module requested but its URL isn't passed from the WebService.
  2. If (1) is enabled and no URL is assigned to the module, the "Open In Browser" button is hidden in the module summary.
  3. Enable feature (1) for the folder addon, and change its description so the inline folder passed in the description from the WebService is not shown.

jleyva and others added 11 commits May 27, 2022 15:08
@jleyva
MOBILE-4082 release: Bump android-versionCode
551fcd8
@dpalou
MOBILE-4090 config: Bump version number for 4.0.2
a4feb0e
@dpalou
MOBILE-4089 forum: Fix infinite loop in getDiscussionsInPages
090107b
@dpalou
MOBILE-4089 forum: Don't fetch all pages when invalidating data
d1cb6b1
@dpalou
MOBILE-4089 forum: Fix wrong parameter passed to prefetchModule
89ef0cc
@dpalou
MOBILE-4091 mycourses: Fix mypage error and empty page
8f66155
@crazyserver
Merge pull request moodlehq#3314 from dpalou/MOBILE-4091
009d984 
MOBILE-4091 mycourses: Fix mypage error and empty page
@crazyserver
Merge pull request moodlehq#3313 from dpalou/MOBILE-4089
ba4ea9b 
Mobile 4089
@crazyserver
Merge pull request moodlehq#3312 from dpalou/MOBILE-4090
73a6642 
MOBILE-4090 config: Bump version number for 4.0.2
@tasosb
MOBILE-4084 core: Add support for hidden views
5fa0429 
Support for views that can exist in the mobile app but are hidden
in the web version so the URL is not passed from the WS.
@tasosb
MOBILE-4084 folder: Restore access to inline folders
c64a0a4 
Add feature HAS_HIDDEN_VIEW to all folders.
Change module description to exclude inline folder data.
@dpalou
Copy link
Contributor

dpalou commented Oct 27, 2022

Just for the record, the final decision on how to solve this was moved to the 4.2 version of the app.

@NoelDeMartin NoelDeMartin changed the title MOBILE-4084 core,folder: Restore access to inline folders MOBILE-4147 core,folder: Restore access to inline folders Sep 27, 2023
@NoelDeMartin NoelDeMartin marked this pull request as draft September 27, 2023 10:01
@NoelDeMartin
Copy link
Member

It seems like this issue is still pending, and it's actually tracked by MOBILE-4147 so I just updated the title and converted it to draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@tasosb @dpalou @NoelDeMartin @jleyva @crazyserver