Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating settings when completion is locked removes completion criteria #105

Open
davosmith opened this issue Jan 16, 2020 · 0 comments
Open

Updating settings when completion is locked removes completion criteria #105

davosmith opened this issue Jan 16, 2020 · 0 comments

Comments

@davosmith
Copy link
Contributor

  1. Create a new course with completion tracking enabled.
  2. Enrol 2 test users
  3. Add a OU blog module with completion requirement: User must make blog posts: 1
  4. Log in as test user and submit blog entry
    Result: OU blog module is marked as completed for test user
  5. change blog settings, for example change subscription mode or blog type and save
    Issue: The completion requirements are removed. It's set to automatic completion still, but the requirement is gone.
  6. Log in as another test user and submit blog entry
    Result: OU blog module is not marked as completed for test user
davosmith added a commit to davosmith/moodle-mod_oublog that referenced this issue Jan 16, 2020
@davosmith
Do not update completion settings when locked moodleou#105
a508053 
If completion settings are locked (because a user has already completed the activity), then the completion settings should be left unchanged in the database, instead of clearing them both to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davosmith