Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the randomness docs #589

Merged
merged 4 commits into from
Mar 28, 2023
Merged

update the randomness docs #589

merged 4 commits into from
Mar 28, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Mar 17, 2023

Description

This PR updates the randomness docs by moving the lottery example to the tutorials section and creating a simple example on the precompile page for generating a random number

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If this page requires a disclaimer, I have added one

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove snippets

Items to be Updated

  • Remove the RandomnessLotteryDemo.sol contract from the code snippets
  • Replace the randomness images with the ones in the new directory

@eshaben eshaben requested a review from albertov19 March 17, 2023 15:21
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback. Looks good! I liked the challenges

tutorials/eth-api/randomness-lottery.md Show resolved Hide resolved
tutorials/eth-api/randomness-lottery.md Outdated Show resolved Hide resolved
@eshaben eshaben requested a review from albertov19 March 28, 2023 17:11
@eshaben eshaben merged commit c6676f1 into master Mar 28, 2023
@eshaben eshaben deleted the eshaben/randomness-docs branch March 28, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants