Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metafab docs #610

Merged
merged 6 commits into from
Apr 12, 2023
Merged

add metafab docs #610

merged 6 commits into from
Apr 12, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Apr 6, 2023 •
edited

Description

This PR uploads the metafab docs that the metafab team provided 馃挏

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If this page requires a disclaimer, I have added one

After Translation Requirements

  • No additional PRs are required after the translations are done

@eshaben eshaben requested a review from albertov19 April 6, 2023 19:24
albertov19
albertov19 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some minor suggestions

builders/integrations/gaming/metafab.md Outdated Show resolved Hide resolved
builders/integrations/gaming/metafab.md Outdated Show resolved Hide resolved
builders/integrations/gaming/metafab.md Outdated Show resolved Hide resolved
builders/integrations/gaming/metafab.md Outdated Show resolved Hide resolved
eshaben and others added 3 commits April 12, 2023 10:25
@eshaben @albertov19
Apply suggestions from code review
9a0b8f7 
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
@eshaben
address feedback
b52ca8f
@eshaben
apply some additional fixes
3e056d7
@eshaben eshaben merged commit 25c8d73 into master Apr 12, 2023
@eshaben eshaben deleted the eshaben/metafab branch April 12, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertov19 albertov19 albertov19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eshaben @albertov19