Create a DApp Tutorial #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshaben
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Another thorough tutorial! Nice job!
Some thoughts:
- The index page icon is missing for the tutorial
- I think for SEO purposes, it would be beneficial to rename the tutorial "How to Build a DApp" - what are your thoughts?
- I didn't do the full grammar check yet but I can do that after some initial changes are made
- This guide could benefit from diagrams of the architecture (made a comment about where to find some)
- New feature: expandable code snippets that I think could come in handy here ✨
- As mentioned in one of my comments, I think this guide would be better suited to be a code-oriented tutorial on architecture rather than a thought process/overview. I'll get back to you on the Web2 vs Web3 blogpost as this is quite similar where they both cover architecture
Co-authored-by: Erin Shaben <eshaben@icloud.com>
eshaben
approved these changes
May 10, 2023
There was a problem hiding this comment.
Sweeeet! Went through and made some grammar and formatting changes. Two major changes made were. The first being to the expandable snippets so they act as recaps of the files as code is added to them (to help avoid confusion). The second is that I also moved some of the content (i.e., setting up the ABI), so that the content is covered right before it is used (i.e., the ABI is used in the read smart contract data section)
Well done! This is a great addition to the docs site! 💜 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A beginner tutorial that helps someone learn the components of every DApp. Might need a change in the section with private keys
Checklist
moonbeam-docs-cnrepo, I have created a ticket for the translations in Jiracompress-images.pyscript to compress the images.After Translation Requirements
moonbeam-docsrepo to remove imagesmoonbeam-docsrepo to remove variablesmoonbeam-mkdocsrepo to add redirects for Chinese site