Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Remote EVM Execution XCM docs for XCM V3 #639

Merged
merged 10 commits into from
May 13, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Apr 27, 2023

Description

This PR updates the Remote Execution docs for XCM V3 and Weights V2. It also uses Polkadot.js API snippets instead of using the Polkadot.js Apps interface.

There are some images are no longer needed for this page, but keeping those in tact for CN version until translations are complete.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images

Items to be Updated

Need to remove the following images:

  • images/builders/interoperability/xcm/remote-evm-calls/xcmevm-2.png
  • images/builders/interoperability/xcm/remote-evm-calls/xcmevm-3.png

@eshaben eshaben changed the title Eshaben/xcm v3 remote evm calls Update Remote Execution XCM docs for XCM V3 Apr 27, 2023
@eshaben eshaben requested a review from albertov19 April 27, 2023 16:01
@eshaben eshaben changed the title Update Remote Execution XCM docs for XCM V3 Update Remote EVM Execution XCM docs for XCM V3 Apr 27, 2023
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a minor comment similar to other PRs.

.snippets/code/remote-execution/send.js Show resolved Hide resolved
@eshaben eshaben requested a review from albertov19 May 11, 2023 05:36
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you see my review on the XCM Transactor PR, maybe we can add a code snippet to handle account decoding? What do you think?

builders/interoperability/xcm/remote-evm-calls.md Outdated Show resolved Hide resolved
albertov19 and others added 3 commits May 11, 2023 16:19
…e/moonbeam-docs into eshaben/xcm-v3-remote-evm-calls
Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
@eshaben
Copy link
Contributor Author

eshaben commented May 12, 2023

Did you see my review on the XCM Transactor PR, maybe we can add a code snippet to handle account decoding? What do you think?

Yeah the comment was on the Send & Execute PR and I made the changes there to include it in the example code snippet. This page doesn't have an existing example where I could implement it, so I added in a small snippet about it

@eshaben eshaben requested a review from albertov19 May 12, 2023 05:01
@eshaben eshaben merged commit 21b6fe2 into master May 13, 2023
1 check passed
@eshaben eshaben deleted the eshaben/xcm-v3-remote-evm-calls branch May 13, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants