Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update hardhat docs #785

Merged
merged 4 commits into from Nov 14, 2023
Merged

update hardhat docs #785

merged 4 commits into from Nov 14, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Nov 9, 2023 •
edited

Description

This PR updates the hardhat docs with the goal of improving the quality of the content. In general, it was slightly restructured, and more content was added to target entry-level developers that may be unfamiliar with Hardhat.

It also adds instructions on how to run a script that does the same actions as the steps to interact with the console.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If images have been added, I have run the compress-images.py script to compress the images.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to update image paths

Items to be Updated

The image path for hardhat-5.png needs to be updated to hardhat-6.png and hardhat-5-new.png to hardhat-5.png

@eshaben eshaben added A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) and removed A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) labels Nov 9, 2023
themacexpert
themacexpert approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I ran thru everything and it worked perfectly.

builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
@eshaben @themacexpert
Update builders/build/eth-api/dev-env/hardhat.md
a274ea9 
Co-authored-by: Kevin Neilson <kevin@purestake.com>
@eshaben eshaben added A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) and removed A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) labels Nov 14, 2023
@eshaben eshaben merged commit 6403fcd into master Nov 14, 2023
1 check passed
@eshaben eshaben deleted the eshaben/hardhat-update-nov-2023 branch November 14, 2023 21:33
@wuzhong-papermoon wuzhong-papermoon mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themacexpert themacexpert themacexpert approved these changes

@albertov19 albertov19 Awaiting requested review from albertov19

Assignees
No one assigned
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eshaben @themacexpert