Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRL Page improvements and xcm fix #892

Merged
merged 8 commits into from
Mar 22, 2024
Merged

MRL Page improvements and xcm fix #892

merged 8 commits into from
Mar 22, 2024

Conversation

themacexpert
Copy link
Contributor

Description

This page improves the asset table on the MRL page and adds information for Moonbase Alpha in addition to Moonbeam. Also includes the xLabs token relayer contract address for both Moonbeam and Moonbase. + Quick fix for XCM page.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Mar 22, 2024
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for grabbing this stuff!!

builders/interoperability/mrl.md Outdated Show resolved Hide resolved
builders/interoperability/mrl.md Show resolved Hide resolved
builders/interoperability/mrl.md Outdated Show resolved Hide resolved
builders/interoperability/mrl.md Show resolved Hide resolved
themacexpert and others added 3 commits March 22, 2024 13:56
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks! ✨🚢 🚀

@eshaben eshaben merged commit 447af5f into master Mar 22, 2024
1 check passed
@eshaben eshaben deleted the themacexpert/xcm branch March 22, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants