Set wasm-runtime-overrides arg in ts tests

moonbeam-foundation · Sep 22, 2021 · 695b082 · 695b082
1 parent 77691aa
commit 695b082
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -306,8 +306,7 @@ jobs:
         if: contains(github.event.pull_request.labels.*.name, 'A10-evmtracing')
         env:
           BINARY_PATH: ../build/moonbeam
-          # `debug` or `trace` require `--wasm-runtime-overrides`. For CI we can provide any directory.
-          ETHAPI_CMD: --ethapi=txpool,debug,trace --wasm-runtime-overrides=/
+          ETHAPI_CMD: --ethapi=txpool,debug,trace
         run: |
           cd moonbeam-types-bundle
           npm install
@@ -428,8 +427,7 @@ jobs:
       - name: Typescript evm-tracing tests (against dev service)
         env:
           BINARY_PATH: ../build/moonbeam-tracing
-          # `debug` or `trace` require `--wasm-runtime-overrides`. For CI we can provide any directory.
-          ETHAPI_CMD: --ethapi=txpool,debug,trace --wasm-runtime-overrides=/
+          ETHAPI_CMD: --ethapi=txpool,debug,trace
         run: |
           cd tests
           node_modules/.bin/mocha --parallel -j 7 -r ts-node/register 'tracing-tests/**/test-*.ts'

diff --git a/tests/util/dev-node.ts b/tests/util/dev-node.ts
@@ -54,7 +54,7 @@ export async function startMoonbeamDevNode(withWasm?: boolean): Promise<{
   const { p2pPort, rpcPort, wsPort } = await findAvailablePorts();
 
   const cmd = BINARY_PATH;
-  const args = [
+  let args = [
     withWasm ? `--execution=Wasm` : `--execution=Native`, // Faster execution using native
     ETHAPI_CMD != "" ? `${ETHAPI_CMD}` : `--ethapi=txpool`,
     `--no-telemetry`,
@@ -67,6 +67,9 @@ export async function startMoonbeamDevNode(withWasm?: boolean): Promise<{
     `--ws-port=${wsPort}`,
     `--tmp`,
   ];
+  if(ETHAPI_CMD != "") {
+    args.push("--wasm-runtime-overrides=/");
+  }
   debug(`Starting dev node: --port=${p2pPort} --rpc-port=${rpcPort} --ws-port=${wsPort}`);
 
   const onProcessExit = function () {