[Staking] Remove delays for bond_more #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4meta5
added
A0-pleasereview
4meta5
removed
the
A3-inprogress
crystalin
approved these changes
Dec 1, 2021
notlesh
reviewed
Dec 1, 2021
| @@ -160,15 +158,9 @@ where | |||
| Action::ScheduleCandidateBondLess => { | |||
| Self::schedule_candidate_bond_less(input, context)? | |||
| } | |||
| // DEPRECATED | |||
There was a problem hiding this comment.
should these still be deprecated or were they not supposed to be deprecated in the first place?
There was a problem hiding this comment.
This is no longer deprecated because candidate_bond_more name and behavior did not change
notlesh
approved these changes
Dec 1, 2021
|
I'm building on the benchmarking server to get proper weights, FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the delay for {candidate, delegator}_bond_more so that the increase is executed immediately, like before #810
Rationale
Increasing stake is similar to joining {candidates, delegators} so no delay is necessary. The delay for bond_less is more consistent with the delay on {revoke, leave}
No migration necessary because #810 was never deployed to any networks