Add BaseFeeElasticity storage value update to migration code
#1744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgmichel
added
A0-pleasereview
girazoki
approved these changes
Aug 12, 2022
|
Do we want to call |
notlesh
approved these changes
Aug 12, 2022
| get_storage_value::<Permill>(module, item, &[]).unwrap_or(Permill::zero()); | ||
| if !current_value.is_zero() { | ||
| // Set Elasticity to zero, which results in constant BaseFeePerGas | ||
| let write = pallet_base_fee::Pallet::<T>::set_elasticity_inner(Permill::zero()); |
There was a problem hiding this comment.
@tgmichel After this, maybe it's time to change the fixed gas price to the base-fee pallet?
There was a problem hiding this comment.
Yes thank you, will do that on a separate PR
|
Is this for RT1800 or RT1900 ? |
|
@crystalin RT1900, which will most likely include polkadot-evm/frontier#794 |
notlesh
added
D1-audited👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
We need to update the storage value for BaseFee::Elasticity to Permill::zero before or at the time we introduce the upstream changes in polkadot-evm/frontier#794
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?