Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Democracy Precompile events #1872

Merged
merged 6 commits into from Nov 4, 2022
Merged

Conversation

nanocryk
Copy link
Contributor

What does it do?

Add EVM events to mirror important Substrate events.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@nanocryk nanocryk added A3-inprogress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Oct 18, 2022
@nanocryk nanocryk marked this pull request as ready for review October 20, 2022 14:26
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
@nanocryk nanocryk merged commit 53b87a8 into master Nov 4, 2022
@nanocryk nanocryk deleted the jeremy-democracy-precompile-events branch November 4, 2022 09:55
imstar15 pushed a commit to OAK-Foundation/moonbeam that referenced this pull request May 16, 2023
* Proposed event

* Seconded

* StandardVote event

* Delegated event

* Undelegated event + costs

* Fix typo

Co-authored-by: Amar Singh <asinghchrony@protonmail.com>

Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-inprogress Pull request is in progress. No review needed at this stage. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants