Add owner admin frezer issuer accessors to assets precompile #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
changed the title
girazoki
added
B7-runtimenoteworthy
…-information-to-asset-precompiles
nbaztec
reviewed
Dec 22, 2022
nbaztec
reviewed
Dec 22, 2022
tests/tests/test-precompile/test-precompile-local-assets-erc20.ts
Outdated
Show resolved
Hide resolved
tests/tests/test-precompile/test-precompile-local-assets-erc20.ts
Outdated
Show resolved
Hide resolved
tests/tests/test-precompile/test-precompile-local-assets-erc20.ts
Outdated
Show resolved
Hide resolved
tests/tests/test-precompile/test-precompile-local-assets-erc20.ts
Outdated
Show resolved
Hide resolved
tests/tests/test-precompile/test-precompile-local-assets-erc20.ts
Outdated
Show resolved
Hide resolved
tests/tests/test-precompile/test-precompile-local-assets-erc20.ts
Outdated
Show resolved
Hide resolved
nbaztec
approved these changes
Dec 22, 2022
nanocryk
approved these changes
Dec 23, 2022
girazoki
deleted the
girazoki-add-more-information-to-asset-precompiles
branch
notlesh
added
D1-audited👍
imstar15
pushed a commit
to OAK-Foundation/moonbeam
that referenced
this pull request
May 16, 2023
…m-foundation#2012) * Add owner admin frezer issuer accessors to precompile * Moves role accesors to its own solidity file * typescript test * prettier Signed-off-by: girazoki <gorka.irazoki@gmail.com> * formatting issues * rework tests to use different accounts * typescript tests, different account for roles Signed-off-by: girazoki <gorka.irazoki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds
owner,issuer,freezerandadminaccessors for assets. I added them to the ERC20.sol precompile, although I can also add them only for local assets if requested.Owner: owner of the asset, can change any other role.
Issuer: account capable of minting tokens for such asset.
Freezer: account capable of freezing an asset.
Admin: account capable of unfreeze and force transfer tokens for an asset.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?