Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Collective precompile call decoding #2083

Merged
merged 3 commits into from Feb 16, 2023
Merged

Improve Collective precompile call decoding #2083

merged 3 commits into from Feb 16, 2023

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Feb 8, 2023

What does it do?

decode_with_depth_limit is preferred over decode

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Feb 8, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Feb 8, 2023
4meta5
4meta5 reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@4meta5 4meta5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, referenda::submit* functions do not need this because they use BoundedCallOf<Runtime>? https://github.com/PureStake/moonbeam/blob/master/precompiles/referenda/src/lib.rs#L260-L264

@nanocryk
Copy link
Contributor Author

To confirm, referenda::submit* functions do not need this because they use BoundedCallOf<Runtime>?

They don't need it because they don't decode the call. It is only from our BoundedBytes to Vec<u8> to Substrate BoundedVec<u8>.

@nanocryk nanocryk merged commit 8073d49 into master Feb 16, 2023
@nanocryk nanocryk deleted the jeremy-collective-precompile-decode-with-depth-limit branch February 16, 2023 14:49
imstar15 pushed a commit to OAK-Foundation/moonbeam that referenced this pull request May 16, 2023
@nanocryk @imstar15
Improve Collective precompile call decoding (moonbeam-foundation#2083)
e14106a 
* use decode_with_depth_limit

* simpler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlesh notlesh notlesh approved these changes

@4meta5 4meta5 4meta5 approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nanocryk @notlesh @4meta5