Update collator candidate self-bond in Moonriver #2139
Conversation
Agusrodri
added
the
D1-runtime-migration
notlesh
added
B7-runtimenoteworthy
runtime/moonriver/src/lib.rs
Outdated
| @@ -674,7 +674,7 @@ impl pallet_parachain_staking::Config for Runtime { | |||
| /// Minimum stake required to become a collator | |||
| type MinCollatorStk = ConstU128<{ 1000 * currency::MOVR * currency::SUPPLY_FACTOR }>; | |||
There was a problem hiding this comment.
Wasn't this discussed to be changed too ?
There was a problem hiding this comment.
Yeah, I realised that I should change this constant too. That´s what I did a few minutes ago and now I'm finishing fixing some tests.
There was a problem hiding this comment.
Shouldn't this imply that MinCandidateStk <= MinCollatorStk? That wasn't the case before this PR, but it seems to be implied:
/// Minimum stake required for any candidate to be in `SelectedCandidates` for the round
#[pallet::constant]
type MinCollatorStk: Get<BalanceOf<Self>>;
/// Minimum stake required for any account to be a collator candidate
#[pallet::constant]
type MinCandidateStk: Get<BalanceOf<Self>>;CC @4meta5
There was a problem hiding this comment.
We should also be careful bumping MinCollatorStk because it could prevent a lot (theoretically all) candidates from being selected for future rounds
There was a problem hiding this comment.
I agree. For now I put the same value in both constants (your bond must be 10000 MOVR to both be selected for the round and be a collator candidate). We should discuss this in more detail and then I change the values and fix tests again if necessary.
Yes! I will definitely add a better description. About tests, I'm finishing fixing some of the integration ones and others within the moonriver runtime that had broken. |
|
@Agusrodri Please verify the vote was approved and merge if that is the case |
notlesh
added
D1-audited👍
…#2139) * change MinCandidateStk constant in moonriver runtime * fix moonriver runtime and integration tests * update chain_spec
What does it do?
According to this referenda https://moonriver.polkassembly.network/referenda/1, the change proposed in this PR is the one that refers to update the bond to 10,000 MOVR in order the collator to be considered eligible and become a collator candidate. The current bond is 500 MOVR.
MinCandidateStkandMinCollatorStkconstants to the value of 10,000 MOVR.Notes
MinCandidateStkrefers to the minimum stake required to be reserved to be a candidate. Located in the moonriver runtimeConfig(lib file).MinCollatorStkrefers to the minimum stake required to become a collator. Located in the moonriver runtimeConfig(lib file).