Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Root to Kill/Cancel referendum for OpenGov #2151

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Allow Root to Kill/Cancel referendum for OpenGov #2151

merged 1 commit into from
Mar 9, 2023

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Mar 8, 2023 •
edited
Loading

What does it do?

Currently, Root origin is not able to kill or cancel an OpenGov referendum in Moonbase/Moonriver. Then, this PR allows Root origin to kill or cancel OpenGov-type referendums within Moonbase and Moonriver.

⚠️ Breaking Changes ⚠️

  • All changes are Moonbase and Moonriver only.

  • Changed CancelOrigin and KillOrigin types within pallet_referenda::Config for Runtime located in
    runtime/moonbase/src/governance/referenda.rs for Moonbase and runtime/moonriver/src/governance/referenda.rs
    for Moonriver.

    Previous values

     type CancelOrigin = ReferendumCanceller;
 type KillOrigin = ReferendumKiller;

    Updated values

     type CancelOrigin = EitherOf<EnsureRoot<Self::AccountId>, ReferendumCanceller>;
 type KillOrigin = EitherOf<EnsureRoot<Self::AccountId>, ReferendumKiller>;

@Agusrodri Agusrodri changed the title added root in moonbase and moonriver referenda OpenGov : Allow Root to Kill/Cancel referendum Mar 8, 2023
@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. D10-breaksdocs Changes to code that require changes in documentation labels Mar 8, 2023
@Agusrodri Agusrodri merged commit a3721de into master Mar 9, 2023
@Agusrodri Agusrodri deleted the agustin-allow-root-in-referenda branch March 9, 2023 19:21
@crystalin crystalin changed the title OpenGov : Allow Root to Kill/Cancel referendum Allow Root to Kill/Cancel referendum for OpenGov Apr 13, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@Agusrodri @imstar15
added root in moonbase and moonriver referenda (moonbeam-foundation#2151
1124f90 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystalin crystalin crystalin approved these changes

@4meta5 4meta5 4meta5 approved these changes

Assignees
No one assigned
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited D10-breaksdocs Changes to code that require changes in documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Agusrodri @crystalin @4meta5 @notlesh