Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PrecompileRegistry precompile to all runtimes #2204

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Add PrecompileRegistry precompile to all runtimes #2204

merged 3 commits into from
Apr 6, 2023

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Apr 4, 2023

What does it do?

Precompile is already added to Moonbase, this PR adds it to Moonriver and Moonbeam.

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority". D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Apr 4, 2023
@nanocryk nanocryk merged commit 478d307 into master Apr 6, 2023
@nanocryk nanocryk deleted the jeremy-precompile-registry-all-runtimes branch April 6, 2023 09:06
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@nanocryk @imstar15
Add PrecompileRegistry precompile to all runtimes (moonbeam-foundatio…
4150a4c 
…n#2204)

* add registry to all runtimes

* update test with removed precompile address

* add view modifiers in .sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C1-low Does not elevate a release containing this beyond "low priority". D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nanocryk @girazoki @notlesh