🧪 dev-test migration to Moonwall #2
#2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbrinded
added
B0-silent
|
Coverage generated "Wed Aug 9 20:26:58 UTC 2023": Master coverage: 87.39% |
timbrinded
changed the title
dev-test migration to Moonwall #2dev-test migration to Moonwall #2
crystalin
approved these changes
Aug 8, 2023
| @@ -48,14 +48,16 @@ | |||
| "@types/yargs": "^17.0.24", | |||
| "@vitest/ui": "^0.31.4", | |||
| "@zombienet/utils": "^0.0.19", | |||
| "chalk": "^5.2.0", | |||
| "chalk": "^5.3.0", | |||
| "eth-object": "github:aurora-is-near/eth-object#master", | |||
There was a problem hiding this comment.
Small library for working with eth primitives, which doesnt work in master (hence point to fork). A test uses this lib to calculate the receipt root based on the emitted logs with logic to add 0x0 if transactiontype envelope is missing (i.e. legacy).
We could fork the fork i guess? Doing it from scratch is a lot of lines for only a single test
* ERC20XCM tests * Add tsx * Moved expect out of xcm helper * Removed unused imports
* Reduce the ConvictionVoting MaxVotes from 512 to 30 * Set MaxVote to 20
* remove leave delegator functionality * remove precompile methods * return error for removed call indices
…onbeam into timbo-migrate-dev-test-2
|
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This is the second large migration of our comprehensive
dev-teststo the Moonwall test framework. It contains updates to the other half of test cases, as well as the new suites for our new features such as PoV estimation and XCM v3.Moonwallv4dev/smoke/paratestsWhat important points reviewers should know?
I have moved existing typescript-tests into a separate
archivefolder so that they won't run in CI (and to make sure devs dont add new tests to this folder). Eventually we can delete these and rely on git history, but i want to keep them around for now for reference.Is there something left for follow-up PRs?
archived_testsfoldertracingtests over/testsfolderWhat value does it bring to the blockchain users?
Improved monitoring and stability of the network(s).