Use barrier from the polkadot-sdk for XCM asset transfer #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noandrea
added
B7-runtimenoteworthy
noandrea
force-pushed
the
noandrea-xcm-barrier-from-upstream
branch
from
326a5cc
to
6910093
Compare
|
Coverage generated "Wed Oct 18 22:55:11 UTC 2023": Master coverage: 87.39% |
the barrier override was introduced as a workarodund to execute multi asset XCM transfer since the limit was set to 1 upstrea, but it has since updated to 2.
noandrea
force-pushed
the
noandrea-xcm-barrier-from-upstream
branch
from
6910093
to
a90f6b0
Compare
Agusrodri
approved these changes
Oct 19, 2023
|
Did we include the corresponding change in the upstream polkadot-sdk? |
|
It would also be nice to apply the same change in orml. |
transferring more than one ERC20 token is not currently supported, and the test for a single ERC20 transfer is already implemented in test-xcm-erc20-transfer.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The barrier override was introduced as a workaround to execute multi-asset XCM transfer since the limit was set to 1 upstream, but it has since been updated to 2.
What does it do?
Remove the override and replace it using the one from upstream