Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vec import in common migrations #2674

Merged
merged 1 commit into from Feb 22, 2024
Merged

Fix vec import in common migrations #2674

merged 1 commit into from Feb 22, 2024

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Feb 22, 2024

What does it do?

Fix a compilation error while building the tracing runtimes:

Build moonbase-2800-substitute-tracing…
║ 🧰 Substrate Runtime Toolbox - srtool v0.13.0 🧰
║ - by Chevdor -
info: using existing install for '1.74.0-x86_64-unknown-linux-gnu'
info: override toolchain for '/build' set to '1.74.0-x86_64-unknown-linux-gnu'
║
║ 1.74.0-x86_64-unknown-linux-gnu unchanged - rustc 1.74.0 (79e9716c9 2023-11-13)
...
║ error: cannot find macro `vec` in this scope
║ --> /home/builder/cargo/git/checkouts/moonbeam-43ea08ca2e3f6df3/e2fae82/runtime/common/src/migrations.rs:326:3
║ |
║ 326 | vec![
║ | ^^^
║ |
║ help: consider importing one of these items
║ |
║ 26 + use frame_benchmarking::__private::vec;
║ |
║ 26 + use parity_scale_codec::alloc::vec;
║ |
║ 26 + use sp_api::vec;
║ |
║ 26 + use sp_std::vec;
║ |
║
║ error: could not compile `moonbeam-runtime-common` (lib) due to previous error

The error exists only for moonbase.

@Agusrodri Agusrodri added D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Feb 22, 2024
Copy link
Collaborator

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦸

@noandrea noandrea added the B0-silent Changes should not be mentioned in any release notes label Feb 22, 2024
@Agusrodri Agusrodri added D2-notlive PR doesn't change runtime/client code and removed D2-notlive PR doesn't change runtime/client code labels Feb 22, 2024
@noandrea noandrea merged commit d1087f3 into master Feb 22, 2024
38 of 41 checks passed
@noandrea noandrea deleted the agustin-fix-import branch February 22, 2024 21:50
Copy link
Contributor

Coverage Report

@@                  Coverage Diff                  @@
##           master   agustin-fix-import     +/-   ##
=====================================================
  Coverage   73.68%               73.68%   0.00%     
  Files         232                  232             
+ Lines       72749                72750      +1     
=====================================================
- Hits        53604                53603      -1     
+ Misses      19145                19147      +2     
Files Changed Coverage

Coverage generated Thu Feb 22 21:53:40 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants