-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polkadot-js types #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests having been modified because types are not used in master yet
I don't understand this part. It seems the tests have not been modified, right?
We also should add some basic integration test. For example make sure tokens can be transferred and the events received via Polkadot JS
I've started to write test using PolkadotJs and will use those files to setup the types correctly. That will allow us to verify they are valid |
Oh, I see. The tests that I saw the other day are not yet in master. So this PR can go in first, and then before @crystalin merges his tests, he'll update them to use these files. That means we don't know whether the comments will be a problem, so I'd say remove them. Final question: Why are there separate |
@joelamouche please make those valid json file. |
done |
tests having been modified because types are not used in master yet
solves MOON-128