Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polkadot-js types #96

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Add polkadot-js types #96

merged 4 commits into from
Nov 9, 2020

Conversation

joelamouche
Copy link
Contributor

  • add json files for the types in a the polkadot-js folder

tests having been modified because types are not used in master yet

solves MOON-128

Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests having been modified because types are not used in master yet

I don't understand this part. It seems the tests have not been modified, right?

We also should add some basic integration test. For example make sure tokens can be transferred and the events received via Polkadot JS

polkadot-js/alphanet-types.json Outdated Show resolved Hide resolved
@crystalin
Copy link
Collaborator

I've started to write test using PolkadotJs and will use those files to setup the types correctly. That will allow us to verify they are valid

@JoshOrndorff
Copy link
Contributor

Oh, I see. The tests that I saw the other day are not yet in master. So this PR can go in first, and then before @crystalin merges his tests, he'll update them to use these files.

That means we don't know whether the comments will be a problem, so I'd say remove them.

Final question: Why are there separate alphanet-types and parachain-types?

@crystalin
Copy link
Collaborator

@joelamouche please make those valid json file.
@JoshOrndorff I asked those 2 types because there might be differences between what we produce as a parachain and what we will produce for alphanet (and other networks). It might be too early to think about it however. @joelamouche can you remove the parachain types for now ?

@joelamouche
Copy link
Contributor Author

done

@joelamouche joelamouche merged commit d01d29d into master Nov 9, 2020
@joelamouche joelamouche deleted the feature/add-polkadot-js-types branch November 9, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants