hongbo/get rid of T (#552)

* remove usage of Array:: * tweak * add missing APIs for hashset * fmt
moonbitlang · Jun 13, 2024 · 84eda7a · 84eda7a
1 parent e795643
commit 84eda7a
Show file tree

Hide file tree

Showing 15 changed files with 142 additions and 90 deletions.
diff --git a/array/array_test.mbt b/array/array_test.mbt
@@ -49,7 +49,7 @@ test "op_equal" {
 }
 
 test "pop" {
-  let v = Array::new()
+  let v = []
   v.push(3)
   v.push(4)
   @assertion.assert_eq(v.length(), 2)?
@@ -60,7 +60,7 @@ test "pop" {
 }
 
 test "pop_exn" {
-  let v = Array::new()
+  let v = []
   v.push(3)
   v.push(4)
   @assertion.assert_eq(v.length(), 2)?
@@ -175,7 +175,7 @@ test "filter" {
 }
 
 test "is_empty" {
-  let v = Array::new()
+  let v = []
   @assertion.assert_true(v.is_empty())?
   v.push(3)
   @assertion.assert_false(v.is_empty())?

diff --git a/array/fixedarray.mbt b/array/fixedarray.mbt
@@ -327,7 +327,7 @@ pub fn FixedArray::from_array[T](array : Array[T]) -> FixedArray[T] {
 }
 
 test "from_array" {
-  let array = FixedArray::[1, 2, 3, 4, 5]
+  let array : FixedArray[_] = [1, 2, 3, 4, 5]
   @assertion.assert_eq(array, [1, 2, 3, 4, 5])?
 }
 

diff --git a/array/fixedarray_sort.mbt b/array/fixedarray_sort.mbt
@@ -52,7 +52,7 @@ fn timsort[T : Compare](arr : FixedArraySlice[T]) -> Unit {
   }
   let mut end = 0
   let mut start = 0
-  let runs : Array[TimSortRun] = Array::new()
+  let runs : Array[TimSortRun] = []
   while end < len {
     let (streak_end, was_reversed) = find_streak(arr.slice(start, arr.end))
     end += streak_end

diff --git a/array/sort.mbt b/array/sort.mbt
@@ -19,9 +19,9 @@
 /// # Example
 /// 
 /// ```
-/// let arr = Array::[5, 4, 3, 2, 1]
+/// let arr = [5, 4, 3, 2, 1]
 /// arr.sort()
-/// debug(arr) //output: Array::[1, 2, 3, 4, 5]
+/// debug(arr) //output: [1, 2, 3, 4, 5]
 /// ```
 pub fn sort[T : Compare](self : Array[T]) -> Unit {
   quick_sort(

diff --git a/array/sort_by.mbt b/array/sort_by.mbt
@@ -19,9 +19,9 @@
 /// # Example
 /// 
 /// ```
-/// let arr = Array::[5, 3, 2, 4, 1]
+/// let arr = [5, 3, 2, 4, 1]
 /// arr.sort_by_key(fn (x) {-x})
-/// debug(arr) //output: Array::[5, 4, 3, 2, 1]
+/// debug(arr) //output: [5, 4, 3, 2, 1]
 /// ```
 pub fn sort_by_key[T, K : Compare](self : Array[T], map : (T) -> K) -> Unit {
   quick_sort_by(
@@ -39,9 +39,9 @@ pub fn sort_by_key[T, K : Compare](self : Array[T], map : (T) -> K) -> Unit {
 /// # Example
 /// 
 /// ```
-/// let arr = Array::[5, 3, 2, 4, 1]
+/// let arr = [5, 3, 2, 4, 1]
 /// arr.sort_by(fn (a, b) { a - b })
-/// debug(arr) //output: Array::[1, 2, 3, 4, 5]
+/// debug(arr) //output: [1, 2, 3, 4, 5]
 /// ```
 pub fn sort_by[T](self : Array[T], cmp : (T, T) -> Int) -> Unit {
   quick_sort_by(