Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Develop a uniform naming convention #41

Closed
Lampese opened this issue Mar 10, 2024 · 3 comments
Closed

Proposal: Develop a uniform naming convention #41

Lampese opened this issue Mar 10, 2024 · 3 comments

Comments

@Lampese
Copy link
Collaborator

Lampese commented Mar 10, 2024

The existing Pull requests are slightly different from the existing code in the core repository in terms of function names and test names. Is it necessary to develop a unified standard to manage?

@fantix
Copy link
Contributor

fantix commented Mar 10, 2024

As well as doc strings.

I would +1 to an overall style guideline in addition to the current CONTRIBUTING tutorial. However, I also understand that things are still moving fast at this early stage and perhaps a loose standard is preferred.

@Lampese
Copy link
Collaborator Author

Lampese commented Mar 11, 2024

As well as doc strings.

I would +1 to an overall style guideline in addition to the current CONTRIBUTING tutorial. However, I also understand that things are still moving fast at this early stage and perhaps a loose standard is preferred.

Maybe you're right, we may have to wait a while to unify these things. This way we can maximize our productivity.

@muqiuhan
Copy link
Contributor

If it is a simple restriction identifier style (such as snake_case or CamelCase), it should not have any impact. The current overall code style is snake_case.

@moonbitlang moonbitlang locked and limited conversation to collaborators Mar 28, 2024
@bobzhang bobzhang converted this issue into discussion #143 Mar 28, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants